Build explicit Ubuntu versions, add Ubuntu 22.04 support - #229
Merged
Conversation
alan-george-lk
marked this pull request as ready for review
August 9, 2026 05:15
alan-george-lk
requested review from
stephen-derosa and
xianshijing-lk
as code owners
August 9, 2026 05:15
stephen-derosa
approved these changes
Aug 24, 2026
stephen-derosa
left a comment
Collaborator
There was a problem hiding this comment.
small questions, LGTM.
Surprised we didnt need any Cmake/deps changes in the repo -- nice!
| # and target/release, which is why the old cache was always ~empty. The | ||
| # restore/save split lets us snapshot the populated target/ before cleanup. | ||
| # | ||
| # Key on matrix.os (runner image), not runner.os. runner.os is just |
Collaborator
There was a problem hiding this comment.
is this comment important or is it more just a note by AI about the diff that could be removed?
Collaborator
Author
There was a problem hiding this comment.
From AI, I also flagged it in the self review, it is worth noting mentally since we have multiple linux builds now so matrix is needed, but is it worth a comment? Perhaps not. I'll remove
| fi | ||
| done | ||
|
|
||
| # Deprecated compatibility aliases for existing Linux release consumers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adjust Linux release to build against explicit Ubuntu 22.04 and 24.04 runners instead of
ubuntu-latest, and publish explicit release artifacts:New:
livekit-sdk-ubuntu-22.04-{x64,arm64}andlivekit-sdk-ubuntu-24.04-{x64,arm64}Deprecated (kept for backwards compatibility):
livekit-sdk-linux-{x64,arm64}(simply repackaged from the existing Ubuntu 24.04 builds)Also fixes Rust
target/cache keys to use matrix.os rather than runner.os, so 24.04-compiled artifacts are not restored on 22.04 runners (which caused GLIBC_2.39 failures). Tests and builds now run on both Ubuntu versions.Testing
Context
In ROS Portal, ROS Humble targets Ubuntu 22.04, and the "linux" LiveKit SDK targets 24.04. The glibc version for 24.04 was not backwards compat on 22.04, but the 22.04 glibc is forwards compatible in 24.04. Thus, we were incurring 30+min SDK build times in ROS Portal CI to rebuild the LiveKit SDK against 22.04.
Therefore in ROS Portal, all LiveKit SDK links will be against 22.04 based artifacts, but will work in 22.04, 24.04, and 26.04 Ubuntu runtime versions for the respective distros.
This approach is also what FoxGlove takes for their SDK/ROS bridge equivalent. Link